Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback implemented and current x added to metadata dictionary of the trace #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viktmar
Copy link
Contributor

@viktmar viktmar commented Oct 17, 2022

the callback is generally useful for more control. I use it myself, but saw also others requesting it. For my use case, early stopping, the current x of each iteration is also required, so I added it to the metadata of the trace. Have all of the trace rather than only the current state, is also important for me.
I am thinking of implementing Early Stopping more directly and efficiently in future. But that is a story for another day.

@pkofod
Copy link
Member

pkofod commented Jun 12, 2023

If you could add a few tests of the functionality I would be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants