Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU pre-compilation #1060

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Enable GPU pre-compilation #1060

merged 6 commits into from
Feb 14, 2025

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Feb 14, 2025

Superseeds #1058 based on @abussy's work.

@mfherbst mfherbst enabled auto-merge (squash) February 14, 2025 13:31
@mfherbst mfherbst disabled auto-merge February 14, 2025 13:48
@mfherbst
Copy link
Member Author

mfherbst commented Feb 14, 2025

@abussy I am really confused by this. Without the check in d5c3d13 the precompilation fails because some methods defined in LibxcCudaExt are not available.

However, this suggests that with this additional check, GPU precompilation will be a avoid operation --- which is also what I find in my experiments (i.e. that on our GPU machine I see no difference with and without this PR).

@abussy
Copy link
Collaborator

abussy commented Feb 14, 2025

For the GPU precompilation to work properly, one needs the latest version of Julia LTS and of the JuliaGPU stack. The test on !isnothing(Base.get_extension(Libxc, :LibxcCudaExt)) is trying to catch this exactly. Before some recent changes were made, extensions were not visible at precompilation. I suspect your testing setup is a little old

@mfherbst
Copy link
Member Author

Ok, thanks, I'll try that.

@mfherbst
Copy link
Member Author

Cool, thanks it works. Saves about a factor of 5 in the startup cost, very impressive.

@mfherbst mfherbst merged commit 64f3dda into master Feb 14, 2025
5 of 8 checks passed
@mfherbst mfherbst deleted the gpu-precompile branch February 14, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants