Make ChainRulesCore a weak dependency #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 38 38
Lines 2414 2414
=======================================
Hits 2082 2082
Misses 332 332 ☔ View full report in Codecov by Sentry. |
|
Great. Thanks so much!! |
|
Nice! |
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 13, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 13, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 13, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445 This forces minimal Julia version to be 1.6
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 13, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445 This forces minimal Julia version to be 1.6
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 13, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445 This forces minimal Julia version to be 1.6
LebedevRI
added a commit
to LebedevRI/Distributions.jl
that referenced
this pull request
Sep 19, 2024
Note that we really do need `Roots.jl` 2.2.0-or-newer, because of JuliaMath/Roots.jl#445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes ChainRulesCore a weak dependency, most importantly to fix JuliaStats/Distributions.jl#1900 (comment) and similar cases in downstream packages that would like to keep their (possibly large) chunk of ChainRules definitions in an extension but currently therefore can't depend on Roots (since it would pull in ChainRulesCore which invalidates the use of an extension in the downstream package and since Pkg is not happy with the circular loading dependency it creates).