Add "missing" irrationals #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump 🙂 In particular |
|
Bump 🙂 |
hyrodium
reviewed
Apr 25, 2022
| invsqrthalfπ # 1 / √(π / 2) | ||
| invsqrtquartπ # 1 / √(π / 4) | ||
| loghalf # log(1 / 2) | ||
| logtwo # log(2) |
There was a problem hiding this comment.
Should this be log2 like log3?
There was a problem hiding this comment.
No, log2 is a function.
| invsqrt2π # 1 / √2π | ||
| invsqrt4π # 1 / √4π | ||
| invsqrthalfπ # 1 / √(π / 2) | ||
| invsqrtquartπ # 1 / √(π / 4) |
There was a problem hiding this comment.
The git diff is a little illegible, so I think it would be better to add more spaces before # for when someone registers a new variable with a long name in another PR.
Suggested change
| invsqrtquartπ # 1 / √(π / 4) | |
| invsqrtquartπ # 1 / √(π / 4) |
Or, it could be fine without aligning #.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some irrationals that seem to be "missing" and would be useful e.g. in SpecialFunctions. E.g., currently
pi(in base),2 * pi,4 * pi,pi / 2, andpi / 4are defined but even though the inverse of all of these numbers is defined as well onlylog(pi),log(2 * pi), andlog(4 * pi)are implemented but neitherlog(pi / 2)norlog(pi / 4). Similarly, currentlysqrt(pi / 4)is not defined (all other square roots are) and only1 / sqrt(2 * pi)is defined but no other inverse square roots.