Fix tests and update with recent changes in Base #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
force-pushed
the
dw/fix_update
branch
from
1c957d1
to
aafbfb2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
===========================================
+ Coverage 98.14% 100.00% +1.85%
===========================================
Files 2 2
Lines 54 64 +10
===========================================
+ Hits 53 64 +11
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
devmotion
force-pushed
the
dw/fix_update
branch
from
aafbfb2
to
f1ab17a
Compare
devmotion
force-pushed
the
dw/fix_update
branch
from
f1ab17a
to
5121078
Compare
Pull Request Test Coverage Report for Build 11251732382Details
💛 - Coveralls |
nsajko
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the test errors (due to method overwritten warnings in the doctests) and incorporates updates (bug fixes + additional tests) from JuliaLang/julia#55911, JuliaLang/julia#54172, JuliaLang/julia#50894 and JuliaLang/julia#46054.