-
Notifications
You must be signed in to change notification settings - Fork 28
Add deprecated message for conversions number to interval #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 99.19% 99.23% +0.04%
==========================================
Files 3 3
Lines 248 261 +13
==========================================
+ Hits 246 259 +13
Misses 2 2
Continue to review full report at Codecov.
|
I would favor a deprecation, that way we don't have to bump the minor version immediately. |
I don’t remember writing these conversions. @daanhb was it you? Any comments? |
@dlfivefifty |
I thought the next release will be v0.7.0 if we resolve #86 with #93. (cf #94) We can release (This is not a strong opinion and I'm okay with the deprecation messages.) |
I'll update this PR with the deprecation messages (x-ref #94 (comment)) |
I like the idea of the deprecation because the standard Julia package management makes it easy to see how to fix things:
|
I don't think I will miss these conversions, at least I don't recall ever using them. In any case there are other ways of converting a number to a domain. |
beb832e
to
0a4423e
Compare
I updated the conversions with deprecated messages.
|
Co-authored-by: Tim Holy <[email protected]>
Note there are quite a few others that should be changed similarly. |
This PR fixes #97.
I just removed the conversion methods. Should we add deprecation messages instead?
I guess the conversions are probably not well used.