Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Traits a bit more stable #203

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Make Traits a bit more stable #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fbe3e4
Use `ManifoldsBase.` prefix in trait macros to make the macros safer …
kellertuer Sep 13, 2024
03c057d
bump version.
kellertuer Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.15.16] 13/09/2024

### Changed

* Adapt the traits, so that they also can be used when only `using ManifoldsBase`,
without importing internal `struct`s like `EmptyTrait` and `TraitList`

## [0.15.15] 29/08/2024

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ManifoldsBase"
uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
version = "0.15.15"
version = "0.15.16"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
6 changes: 3 additions & 3 deletions src/nested_trait.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,14 @@ macro trait_function(sig, opts = :(), manifold_arg_no = 1)
return ($fname)(trait($fname, $(argnames...)), $(argnames...); $(kwargs_call...))
end
@inline function ($fname)(
_t::TraitList,
_t::ManifoldsBase.TraitList,
$(callargs...);
$(kwargs_list...),
) where {$(where_exprs...)}
return ($fname)(next_trait(_t), $(argnames...); $(kwargs_call...))
end
@inline function ($fname)(
_t::TraitList{IsExplicitDecorator},
_t::ManifoldsBase.TraitList{ManifoldsBase.IsExplicitDecorator},
$(callargs...);
$(kwargs_list...),
) where {$(where_exprs...)}
Expand All @@ -339,7 +339,7 @@ macro trait_function(sig, opts = :(), manifold_arg_no = 1)
# See https://discourse.julialang.org/t/extremely-slow-invoke-when-inlined/90665
# for the reasoning behind @noinline
@noinline function ($fname)(
::EmptyTrait,
::ManifoldsBase.EmptyTrait,
$(callargs...);
$(kwargs_list...),
) where {$(where_exprs...)}
Expand Down
Loading