Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance of power manifold creation and more #197

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

mateuszbaran
Copy link
Member

The ManifoldsBase.jl improvements that are needed for better performance of IPM.

Note: constraints are creating new PowerManifolds at every access and these constructors were type-unstable before these changes, creating significant slowdowns.

get_component(M::ProductManifold, p, i) with integers is still slow and I didn't really want to sprinkle everything with Base.@constprop :aggressive to try to improve it.

@mateuszbaran mateuszbaran added the enhancement New feature or request label Aug 2, 2024
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you know that this is faster ;)

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (2ac6a52) to head (50fcb95).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          31       31           
  Lines        3292     3294    +2     
=======================================
+ Hits         3289     3291    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran mateuszbaran merged commit 99ff139 into master Aug 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants