Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info/warn print of checks #182

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Jan 24, 2024

As we noticed in Manifolds.jl/#702 sometimes errors printed on info/warn errored themselves

This was due to a “hardcoded” print using e.val and e.msg which not all errors might have.

This PR fixes that by using showerror instead, which errors should implement anyways.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65780dc) 99.96% compared to head (5ded609) 99.96%.
Report is 1 commits behind head on master.

❗ Current head 5ded609 differs from pull request most recent head 034c08c. Consider uploading reports for the commit 034c08c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          27       27           
  Lines        3093     3107   +14     
=======================================
+ Hits         3092     3106   +14     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Jan 24, 2024
@kellertuer kellertuer merged commit b7665ae into master Jan 24, 2024
13 checks passed
@kellertuer kellertuer deleted the kellertuer/fix-error-prints branch May 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants