-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify error=
keyword
#170
Unify error=
keyword
#170
Conversation
But there seem to be a few dispatches through the decorators that are quite tricky still. |
One thing missing as well is that edit: For now there is a fix, but still info/warn basically only work for |
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 26 26
Lines 3065 3063 -2
==========================================
- Hits 3064 3062 -2
Misses 1 1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
In principle this PR is finished – Docs are updated, even the tutorial (but the push to Documenter 1.0 comes from another PR, the tutorial is updated here already) |
# Conflicts: # NEWS.md # docs/Project.toml # tutorials/Project.toml
I just had to adapt 2 tests from the other PRs, merged the NEWS – there we only have to enter the date when we merge/register 0.15 |
Co-authored-by: Mateusz Baran <[email protected]>
Do we adapt tests like |
Yes. I wrote that in detail in the NEWS.md, to unify all signatures I had to switch 2 positionals. |
I see, sorry -- I forgot to read NEWS.md. |
The CI issue is really werid... |
Yes. It worked on the comment before so maybe let's wait a bit or check whether they did something to that package? (I am on mobile currently). |
I've tried tracking it and I suspect JuliaRegistries/General#93498 is the issue. |
I've mostly updated Manifolds.jl. Could you take a look why a wrong exception type is throws in |
Not today, maybe tomorrow before my lecture, otherwise only early evening (travelling to Oslo in the afternoon) |
No problem, it can wait. |
I checked them and adapted the tests – indeed they now show “X error caused by Y error” which even looks nicer than the ManifoldDomainErrors (that we still have in other places where they fit better). |
Thanks! |
This resolves #135.