Make Traits a bit more stable (#203)

* Use `ManifoldsBase.` prefix in trait macros to make the macros safer when used outside of ManifoldsBase.
* bump version.

NEWS.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.15.16] 13/09/2024
+
+### Changed
+
+* Adapt the traits, so that they also can be used when only `using ManifoldsBase`,
+without importing internal `struct`s like `EmptyTrait` and `TraitList`
+
 ## [0.15.15] 29/08/2024
 
 ### Changed

Project.toml

@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.15.15"
+version = "0.15.16"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/nested_trait.jl

@@ -306,14 +306,14 @@ macro trait_function(sig, opts = :(), manifold_arg_no = 1)
             return ($fname)(trait($fname, $(argnames...)), $(argnames...); $(kwargs_call...))
         end
         @inline function ($fname)(
-            _t::TraitList,
+            _t::ManifoldsBase.TraitList,
             $(callargs...);
             $(kwargs_list...),
         ) where {$(where_exprs...)}
             return ($fname)(next_trait(_t), $(argnames...); $(kwargs_call...))
         end
         @inline function ($fname)(
-            _t::TraitList{IsExplicitDecorator},
+            _t::ManifoldsBase.TraitList{ManifoldsBase.IsExplicitDecorator},
             $(callargs...);
             $(kwargs_list...),
         ) where {$(where_exprs...)}
@@ -339,7 +339,7 @@ macro trait_function(sig, opts = :(), manifold_arg_no = 1)
             # See https://discourse.julialang.org/t/extremely-slow-invoke-when-inlined/90665
             # for the reasoning behind @noinline
             @noinline function ($fname)(
-                ::EmptyTrait,
+                ::ManifoldsBase.EmptyTrait,
                 $(callargs...);
                 $(kwargs_list...),
             ) where {$(where_exprs...)}