Skip to content

get it working on 1.12 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Conversation

araujoms
Copy link
Contributor

While #147 isn't ready I think it's worth tolerating the alg kwarg so that it works on 1.12.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (9e5cb8b) to head (157bb1a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          10       10           
  Lines        1547     1547           
=======================================
  Hits         1419     1419           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

@andreasnoack andreasnoack merged commit db0683d into JuliaLinearAlgebra:master Apr 26, 2025
8 checks passed
@araujoms
Copy link
Contributor Author

My pleasure. Could you please release a new version with it? Then I could get my own package working with 1.12.

@araujoms
Copy link
Contributor Author

Thanks!

@araujoms araujoms deleted the alg branch April 26, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants