Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSOC proposal for FastDifferentiation.jl #2238

Merged
merged 6 commits into from
Feb 9, 2025

Conversation

brianguenter
Copy link
Contributor

@xlxs4 This is my proposal for GSOC.

@ViralBShah
Copy link
Member

@xlxs4 Merge?

@xlxs4
Copy link
Contributor

xlxs4 commented Feb 8, 2025

Thanks for the writeup @brianguenter! A few comments:

  • Maybe add a high-level description of FastDifferentiation?
  • As stated in the GSoC docs, it's good to not provide a fleshed-out plan on how to see the project through. I was wondering, however, if the Expected Outcome sections could be slightly rephrased to be a bit more specific?
  • Similarly, perhaps consider rephrasing some of the text in Recommended Skills -- I can understand how, e.g., the first listed project requires mostly experience with the Julia programming language, but doesn't the second project depend more on the theoretical background? Reading off of "[...] as well as some theoretical work to determine which higher order terms can be reused."

LGTM other than these minor comments

@brianguenter
Copy link
Contributor Author

@xlxs4 thanks for the suggestions. I've made changes 1 and 3 you suggested.

Not sure how to do 2 without being redundant, i.e., repeating in the Expected Outcome section what was already stated in the description of work. Do you think this is necessary? Can you point me to an example to help me understand what Google is expecting in this section? I looked at a couple of the other proposals and their Expected Outcome sections look very similar to mine, or they don't have this section at all.

@xlxs4
Copy link
Contributor

xlxs4 commented Feb 9, 2025

It's great as it is. LGTM @ViralBShah

@ViralBShah ViralBShah merged commit 255fda6 into JuliaLang:main Feb 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants