Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MedPipe3D_JSOC_proposal #2014

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

jakubMitura14
Copy link
Contributor

@jakubMitura14 jakubMitura14 commented Jan 11, 2024

Adding JSOC proposal.

Copy link
Contributor Author

@jakubMitura14 jakubMitura14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding JSOC proposal. Suggested reviewer Jacob Zelko

@TheCedarPrince Cedar prince do not display on ossible reviewer list

Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Left some comments/suggestions. The biggest comment is just the first comment -- feel free to integrate or reject the others as you see fit. Exciting! 😄

@@ -0,0 +1,82 @@
# MedPipe3D Projects

MedPipe3D.jl together with MedEye3D.jl MedEval3D.jl and currently in development MedImage.jl is a set of libraries created to provide essential tools for 3D medical imaging to the Julia language ecosystem. Recently all of the projects migrated also to the JuliaHealth organization to improve packages visibility and promote interoperability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on this piece:

  1. Could you link the repositories here for each package you mentioned?
  2. Could you make a markdown list to explain what (in just a few words) what each package does generally?
  3. I'd remove the line about package migration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you actually make the PR against this file: https://github.com/JuliaLang/www.julialang.org/blob/c35d1b42090ce631a46a221996446d3ecc9c6700/jsoc/gsoc/juliahealth.md?plain=1 ?

And then add a section for the Medical Imaging Subecosystem with the projects you have here listed underneath it?

Comment on lines 19 to 22
- **Suggested Skills and Background**:
- Experience with Julia
- Basic familiarity with computer graphics preferably OpenGL
- Some experience with 3d volumetric data with spatial metadata (or a willingness to learn!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, but in the past, students have found it helpful when I list what packages to be familiar with as well as any links to requisite background knowledge (youtube videos, articles, etc.). Might want to consider adding them in.

### Project 2: Adding dataset-wide functions and integrations of augmentations

**Description:**
MedPipe3D was created as a package that improves integration between other parts of the small ecosystem (MedEye3D, MedEval3D, and MedImage). Currently, it needs to be expanded and adapted so it can be a basis for a fully functional medical imaging pipeline.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand this description further to say in what ways it needs to be expanded/adapted?

This set of changes although time-consuming to implement should not pose a significant issue to anybody with experience with the Julia programming language. However, implementing those will be a huge step in making Julia language a good alternative to Python in developing end-to-end medical imaging segmentation algorithms.

- **Success criteria and time needed:** How the success of functionality described above is defined and the approximate time required for each.
For each point mentor will also supply the person responsible for implementation with examples of required functionalities in Python or will point to the Julia libraries already implementing it (that just need to be integrated).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line?

@TheCedarPrince TheCedarPrince merged commit bfcbdf3 into JuliaLang:main Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants