Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable from endswith #56934

Merged

Conversation

llbit
Copy link
Contributor

@llbit llbit commented Jan 2, 2025

This is a trivial code cleanup suggestion. The cub variable was unused in endswith(::Union{String, SubString{String}}, ::Union{String, SubString{String}}).

I ran the tests with make test, there were some failures but they did not appear to be related to the change.

@fredrikekre fredrikekre added the merge me PR is reviewed. Merge when all tests are passing label Jan 2, 2025
@jishnub jishnub merged commit a393c6f into JuliaLang:master Jan 2, 2025
6 of 8 checks passed
@jishnub jishnub removed the merge me PR is reviewed. Merge when all tests are passing label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants