Don't report only-inferred methods as recompiles #56914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
backport 1.11
IanButterworth
force-pushed
the
ib/fix_recompile_trace
branch
2 times, most recently
from
995e64e to
8152312
Compare
nsajko
added
the
observability
vtjnash
reviewed
Dec 30, 2024
Co-authored-by: Jameson Nash <[email protected]>
IanButterworth
force-pushed
the
ib/fix_recompile_trace
branch
from
fbf7b97 to
6ec844b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56155
If I run the test in #56155 (comment) the
--trace-compileoutput contains no# recompileat all, but specifically not forcontractuser.And the test added here ensures that it is actually catching a true recompilation.