Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aggressive constprop annotation on generic_matmatmul_wrapper! #56400

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Remove aggressive constprop annotation on generic_matmatmul_wrapper! #56400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352770a
Remove aggressive constprop annotation on generic_matmatmul_wrapper!
jishnub Oct 31, 2024
340e409
Merge branch 'master' into jishnub/generic_matmul_wrapper_constprop
jishnub Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ end
# this indirection allows is to specialize on the types of the wrappers of A and B to some extent,
# even though the wrappers are stripped off in mul!
# By default, we ignore the wrapper info and forward the arguments to generic_matmatmul!
Base.@constprop :aggressive function generic_matmatmul_wrapper!(C, tA, tB, A, B, α, β, @nospecialize(val))
function generic_matmatmul_wrapper!(C, tA, tB, A, B, α, β, @nospecialize(val))
generic_matmatmul!(C, tA, tB, A, B, α, β)
end

Expand Down