fixes for rationalizing irrationals #55853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
rationals
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Sep 26, 2024
Other changes: * replace `:total` with the less powerful `:foldable` * add an `<:Integer` dispatch constraint on the `rationalize` method, closes JuliaLang#55872 * replace `Rational{<:Integer}` with just `Rational`, they're equal Other issues, related to `BigFloat` precision, are still present in irrationals.jl, to be fixed by followup PRs, including JuliaLang#55853. Fixes JuliaLang#55874
nsajko
force-pushed
the
rationalize_irrational
branch
from
c4735e9
to
d75ffb5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nsajko
force-pushed
the
rationalize_irrational
branch
3 times, most recently
from
31c2f68
to
9548a41
Compare
vtjnash
pushed a commit
that referenced
this pull request
Oct 10, 2024
Other changes: * replace `:total` with the less powerful `:foldable` * add an `<:Integer` dispatch constraint on the `rationalize` method, closes #55872 * replace `Rational{<:Integer}` with just `Rational`, they're equal Other issues, related to `BigFloat` precision, are still present in irrationals.jl, to be fixed by followup PRs, including #55853. Fixes #55874
Fixes several issues: * Set `BigFloat` precision without mutating the global default, relying on the new ScopedValues functionality. * Avoid reading the global defaults for the precision and rounding mode, relies on JuliaLang#56095. * Try to ensure the loop terminates in a reasonable amount of time, and without trying to allocate excessively large `BigFloat` values.
nsajko
force-pushed
the
rationalize_irrational
branch
from
9548a41
to
e2cfacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues:
BigFloatprecision without mutating the global default, relyingon the new ScopedValues functionality.
mode, relies on Base.MPFR: avoid reading the global defaults unless necessary #56095.
without trying to allocate excessively large
BigFloatvalues.