-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make threadpoolsize(), threadpooltids(), and ngcthreads() public #55701
Make threadpoolsize(), threadpooltids(), and ngcthreads() public #55701
Conversation
(bump) |
|
But I need to care about it 😅 For context, this is the usecase that motivated the PR: https://github.com/Gnimuc/CImGui.jl/blob/7c315112271b61d59c35873a2f1691021fb40198/ext/GlfwOpenGLBackend.jl#L177 That function allows pinning a task on a specific thread or in a given threadpool, which is sometimes necessary for libuv/GLFW reasons, but to do that I do need a valid thread ID. I could try recomputing the valid thread IDs but that's not completely trivial going from the definition so I feel that it would better if this was public. |
Making something public is a commitment to an API, which we are not ready to make. It's often fine to access internals, but you need to be aware of the fact that you are doing so (and you don't get to complain when a future Julia version changes things on you). So |
These are already mentioned in the docs.
7ed0d87
to
5ecd21c
Compare
Ok, fair enough 👍 I rebased the branch and removed |
Bump, AFAICS the test failures are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that they are already in the manual, so this is just a bugfix really.
threadpoolsize()
andngcthreads()
were already in the docs anyway, andthreadpooltids()
is useful for checking which threads belong to a pool.