Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid materializing arrays in bidiag matmul #55450

Merged
merged 13 commits into from
Sep 10, 2024
+422 −68
Merged

Avoid materializing arrays in bidiag matmul #55450

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f9c2db1
Avoid materializing arrays in bidiag matmul
jishnub Aug 10, 2024
2c56cf8
Make iteration cache-friendly in Bidiagonal matmul
jishnub Aug 10, 2024
974425c
Cherry-pick changes from jishnub/bidigamul_empty
jishnub Aug 10, 2024
fc3387f
Specialize Bidiagonal * AbstractVecOrMat
jishnub Aug 10, 2024
11de30c
Fix field access
jishnub Aug 11, 2024
2b443dc
Split bibimul into cases
jishnub Aug 11, 2024
d03767b
Fix undef variables in __bibimul
jishnub Aug 11, 2024
b70b693
_diag for SymTridiagonal
jishnub Aug 11, 2024
2d15c70
Column-major iteration in bibimul
jishnub Aug 12, 2024
8f30cdc
Tests for a matrix-valued eltype
jishnub Aug 12, 2024
e27d7ea
Merge branch 'master' into jishnub/bidiag_naivemul
dkarrasch Aug 25, 2024
b5ccf5b
Merge branch 'master' into jishnub/bidiag_naivemul
jishnub Aug 28, 2024
c2fcdd1
Merge branch 'master' into jishnub/bidiag_naivemul
jishnub Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/LinearAlgebra/src/LinearAlgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ matprod_dest(A::Diagonal, B::Diagonal, TS) = _matprod_dest_diag(B, TS)
_matprod_dest_diag(A, TS) = similar(A, TS)
function _matprod_dest_diag(A::SymTridiagonal, TS)
n = size(A, 1)
Tridiagonal(similar(A, TS, n-1), similar(A, TS, n), similar(A, TS, n-1))
ev = similar(A, TS, max(0, n-1))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes ev allocation for n==0

dv = similar(A, TS, n)
Tridiagonal(ev, dv, similar(ev))
end

# Special handling for adj/trans vec
Expand Down
Loading