inference: Allow any non-nothing source in ci_has_source for extern owner #55294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wner In updating DAECompiler to the new engine API, I was running some trouble, because the source it produces is not a `CodeInfo` or a `String` (which is fine because it has a non-nothing `owner`). Adjust the test to consider any non-nothing value in .inferred valid source (at least for non-nothing CI owners).
aviatesk
approved these changes
Jul 29, 2024
vtjnash
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Looks fine, but note that currently there are no callers that set SOURCE_MODE_FORCE_SOURCE that actually want the behavior specified by this function currently (both want it to either produce LLVM IR for including in staticdata output or to a have a constant value). We will probably need to figure that specification issue eventually.
|
Yeah, all of this isn't fully fleshed out yet, I'm just trying to get things working again. Let's revisit all of these interfaces once your larger refactor is fully in. |
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
…wner (JuliaLang#55294) In updating DAECompiler to the new engine API, I was running some trouble, because the source it produces is not a `CodeInfo` or a `String` (which is fine because it has a non-nothing `owner`). Adjust the test to consider any non-nothing value in .inferred valid source (at least for non-nothing CI owners).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updating DAECompiler to the new engine API, I was running some trouble, because the source it produces is not a
CodeInfoor aString(which is fine because it has a non-nothingowner). Adjust the test to consider any non-nothing value in .inferred valid source (at least for non-nothing CI owners).