Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete Bottom from Base #55293

Closed
wants to merge 2 commits into from
Closed

delete Bottom from Base #55293

wants to merge 2 commits into from

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Jul 28, 2024

Having it is unnecessary, given Union{}, and confusing, now that Top is gone.

Fixes #55292

@nsajko
delete Bottom from Base
f02f6f2 
Having it is unnecessary, given `Union{}`, and confusing, now that
`Top` is gone.

Fixes JuliaLang#55292
@nsajko nsajko added needs pkgeval Tests for all registered packages should be run with this change minor change Marginal behavior change acceptable for a minor release labels Jul 28, 2024
Keno
Keno requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong NAK on this. It's good for fundamental things like this to have an identifier even if they're mostly used a different syntactic construct.

@nsajko nsajko closed this Jul 28, 2024
@nsajko nsajko deleted the delete_Bottom_from_Base branch July 28, 2024 22:35
@nsajko nsajko removed the needs pkgeval Tests for all registered packages should be run with this change label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno requested changes

Assignees
No one assigned
Labels
minor change Marginal behavior change acceptable for a minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base.Bottom is referred to in the Union{} doc string, but it's not public
2 participants
@nsajko @Keno