-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable reserved_stack argument to Threads.@spawn
#55201
base: master
Are you sure you want to change the base?
Conversation
@ararslan both have been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of mixing both keyword argument and positional style in macros.
It makes them quite a bit harder to read. I would make the order required with threadpool; kwargs...
like a normal function call.
I wonder if we could factor out the logic of parsing the kwargs to the macro.
It looks similar to gen_call_with_extracted_types_and_kwargs
I was meaning to ask about this. Is there was a standard way to handle kwargs in Julia macros that live in Base? |
Fixes #55200. The mechanism is to simply forward whatever is passed to a
reserved_stack
keyword to thereserved_stack
argument inTask
. By default this is 0, so that is also the macro default.Usage:
It is compatible with the threadpool argument, and the order is arbitrary:
x-ref #55200 #55185 #55184 #54998