Make ASAN build not be debug, following clangs recommendation #54094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs JuliaCI/julia-buildkite#349 to actually have effect |
Keno
approved these changes
Apr 16, 2024
|
So bootstrapping with O1 is quite a bit faster 🤔 |
|
But building the pkgimages of the stdlibs is still quite slow, no? |
|
Yes, it might be worth it to understand why ASAN is so expensive for us, I believe the expected overhead is 2x and we are seeing almost 4 and for pkgimages it's almost 20x but this still halves the time by half |
|
Can this this merged since it does sensibly improve ASAN build time, and further improvement can be done in follow up PR? |
|
@gbaraldi any objection to backporting this PR to v1.11? |
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit 6c17db1)
|
I backported it because asan fails all the time on 1.11. Maybe this will help. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 24, 2024
(cherry picked from commit 6c17db1)
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following LLVMs/Googles recommendation, ASAN should be run with optimization otherwise performance is awful (which it is for us). The asan build is currently by far the longest and it's just a build. I would like for us to one day run ASAN and TSAN tests and maybe even MSAN, but ASAN is the cheapest and less hassly to do it, because it has false negatives instead of false positives like the other sanitizers.
TODO: Make the setting respect if the user asked for a debug build or not.