alignment-hack jl_task_t to bring it back from the size 400 to the size 368 pool #49088
Conversation
|
That's a good idea! |
|
There's also the version where we only store ip/sp and let the compiler spill everything else by calling convention. |
|
@StefanKarpinski also has been thinking about ways to get the rng state down from 32 to 24 bytes |
src/julia.h
Outdated
| @@ -1958,6 +1948,13 @@ typedef struct _jl_task_t { | |||
| size_t bufsz; // actual sizeof stkbuf | |||
| unsigned int copy_stack:31; // sizeof stack for copybuf | |||
| unsigned int started:1; | |||
There was a problem hiding this comment.
Can we fold started into the reentrant_timing field? Otherwise started and copystack don't have a known location in the struct, which makes identifying padding bytes harder.
|
The splittable RNG stuff adds 64 bits (8 bytes), but I do have an idea for a hybrid xoroshiro128/pcg64 RNG that would have a large cycle, avoid the pitfalls of each of the components, and only take 192 bits (24 bytes), so that would compensate for the additional 8 bytes for the splittable part. So after my recent change the total RNG state is 5 64-bit words but I could potentially get it back down to 4 64-bit words, which is what it was before. |
|
Requires a test update to llvmpasses |
No description provided.