Fix stdlib paths in stacktraces #35890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
May 14, 2020
| @@ -496,7 +496,8 @@ function show_method_candidates(io::IO, ex::MethodError, @nospecialize kwargs=() | |||
| print(iob, "; ") | |||
| join(iob, kwords, ", ") | |||
| end | |||
| print(iob, ")") | |||
| file ,line =updated_methodloc(method) | |||
There was a problem hiding this comment.
indentation and spaces look a bit off here
fredrikekre
changed the title
|
Is this still alive? I'd love to see this fixed (thanks, @Sagnik-Chatterjee) |
|
I realize now that the approach here is not entirely correct (sorry for giving a bad suggestion). As it is, it will give the line number to the start of the method. |
|
closed in favor of #37427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this hopefully solves #35191