optimize Symbol with constant string argument
#32437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:inference
vtjnash
reviewed
Jun 27, 2019
| ncodeunits(s::String) = Core.sizeof(s) | ||
| sizeof(s::String) = Core.sizeof(s) | ||
| @pure ncodeunits(s::String) = Core.sizeof(s) | ||
| @pure sizeof(s::String) = Core.sizeof(s) |
There was a problem hiding this comment.
I think inference is supposed to know this one already, and might just need a minor fix
There was a problem hiding this comment.
Actually a while ago I specifically told the compiler not to constant prop Strings since it led to extremely long compile times for some packages (if I recall, DiffEq parsing many string literals to input numeric constants).
There was a problem hiding this comment.
purity detection should be able to infer this independently of constant prop though and mark it as pure
|
Conflicts with the premise of #32368, but otherwise this does seem desirable. |
JeffBezanson
force-pushed
the
jb/puresymbol
branch
from
64f46b8 to
3788389
Compare
|
Bump. |
|
Re-bump. |
|
Re-re-bump. |
vtjnash
approved these changes
Nov 27, 2019
JeffBezanson
force-pushed
the
jb/puresymbol
branch
from
3788389 to
9ad8bc8
Compare
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently code with
Symbol("x")instead of:xdoes not get optimized at all, which could be a gotcha. Allow constant inferring symbol<->string conversions, and allow Symbol as an inlined constant.