Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: added method for quantile(v::AbstractArray, ...) #31026

Closed
wants to merge 2 commits into from
Closed

RFC: added method for quantile(v::AbstractArray, ...) #31026

wants to merge 2 commits into from

Conversation

heliosdrm
Copy link
Contributor

@heliosdrm
Copy link
Contributor Author

heliosdrm commented Feb 10, 2019 •
edited
Loading

A more generic alternative would be changing the method un line 916 by:

quantile(itr, p; sorted::Bool=false) = quantile!(vec(collect(itr)), p, sorted=sorted)

But the current proposal is more performant for AbstractArray specifically, because no copy is made.

nalimilan
nalimilan approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and welcome!

@IanButterworth IanButterworth mentioned this pull request Nov 4, 2022
Open
@IanButterworth
Copy link
Sponsor Member

Seems like a good idea but I'm closing as Statistics is now an external stdlib repo.
Here's a new issue over there to not forget this JuliaStats/Statistics.jl#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heliosdrm @IanButterworth @nalimilan