Fix a few offset indexing bugs #28100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, ImageFiltering is an extremely good test case for offset indexing in Julia. Anyone who wants to continue the challenge of getting it to work on 0.7, see JuliaImages/ImageFiltering.jl#65 |
mbauman
approved these changes
Jul 13, 2018
|
Given that there are approximately 2 dozen CircleCI builds waiting in queue before we get to this PR, and given that we're about to tag the beta, and given that this PR is going to be very helpful in getting packages up to speed… I say we merge this now. |
Done. 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to port ImageFiltering I found a few indexing bugs. Two (or perhaps all 3) are probably consequences of #27038, for which I think the balance of arguments is clearly positive, though also a very deep change that we should expect will have a few more undetected consequences.
As I am about to be incommunicado for a couple of weeks, I'm basically tossing this over the fence for someone else to pick up.