Skip to content

inference: avoid world age assertion #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2017
Merged

inference: avoid world age assertion #24449

merged 1 commit into from
Nov 6, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 2, 2017

This was over-aggressive. It was only correct in the case where we where
depending on the .inferred field or .rettype contents exactly.
However, sometimes inference of the method instead depends on .def.source.

fix #23981
fix #23768

This was over-aggressive. It was only correct in the case where we where
depending on the `.inferred` field or `.rettype` contents exactly.
However, sometimes inference of the method instead depends on `.def.source`.

fix #23981
fix #23768
@ararslan ararslan added bugfix This change fixes an existing bug compiler:inference Type inference labels Nov 2, 2017
@quinnj
Copy link
Member

quinnj commented Nov 2, 2017

CI failures look unrelated (same failures we saw on NamedTuple PR yesterday)

@vtjnash vtjnash merged commit 6b3dd9d into master Nov 6, 2017
@vtjnash vtjnash deleted the jn/23768-23981 branch November 6, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World age assertion adding backedges Crash when loading DataFrames w/ make debug
3 participants