adding tests to unzip #21212
Closed
adding tests to unzip #21212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~~@StefanKarpinski~~ Julia needs an underling to give this PR a shot. [#13942](#13942). 1. I know I'm clearly missing some important things, but I hope the effort counts. I couldn't find a way to get the rows from the array comprehension... 2. Willing to start over from scratch - any comments/critiques/suggestions more than welcome. 3. I am first trying a MWE with simple structure and inputs. Then I will try to get something that works more generically. Is this a good way to procceed? [ci skip] Roadmap: * Verify each returned array is the same type as the types of the elements * Verify lengths of all arrays to be unzipped * Return as a single Array of Arrays or as separate Arrays? * Remove that `zip is its own inverse` in `@doc zip`? * Revise documentation phrasing and example
update julia fork
~~@StefanKarpinski~~ Julia needs an underling to give this PR a shot. [#13942](#13942). 1. I know I'm clearly missing some important things, but I hope the effort counts. I couldn't find a way to get the rows from the array comprehension... 2. Willing to start over from scratch - any comments/critiques/suggestions more than welcome. 3. I am first trying a MWE with simple structure and inputs. Then I will try to get something that works more generically. Is this a good way to procceed? [ci skip] Roadmap: * Verify each returned array is the same type as the types of the elements * Verify lengths of all arrays to be unzipped * Return as a single Array of Arrays or as separate Arrays? * Remove that `zip is its own inverse` in `@doc zip`? * Revise documentation phrasing and example
|
Sorry, I didn't mean to duplicate an issue, I was just trying to edit my initial PR #21208 and clicking at seemingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.