Skip to content

fixes and stronger tests for SymTridiagonal setindex! #20901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2017
Merged

fixes and stronger tests for SymTridiagonal setindex! #20901

merged 1 commit into from
Mar 8, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Mar 5, 2017

Ref. discussion in #20886. This pull request makes SymTridiagonal setindex! no longer support off-diagonal assignment of any form and strengthens associated tests. Best!

@Sacha0 Sacha0 added bugfix This change fixes an existing bug linear algebra Linear algebra labels Mar 5, 2017
@Sacha0 Sacha0 added this to the 0.6.x milestone Mar 5, 2017
@ararslan
Copy link
Member

ararslan commented Mar 6, 2017

Isn't this technically a breaking change since SymTridiagonal does currently support off-diagonal assignment? Would that disqualify it from the 0.6.x milestone, as we've already entered 0.6 feature freeze? cc @tkelman

@tkelman
Copy link
Contributor

tkelman commented Mar 6, 2017

It supports off diagonal assignment but shouldn't, so this is fixing a bug of setindex writing to multiple values which it shouldn't.

@ararslan
Copy link
Member

ararslan commented Mar 6, 2017

Got it. Thanks!

@tkelman
Copy link
Contributor

tkelman commented Mar 6, 2017

you may want to adjust the tests/comments I changed at https://github.com/JuliaLang/julia/pull/20906/files to reflect this

@Sacha0
Copy link
Member Author

Sacha0 commented Mar 6, 2017

you may want to adjust the tests/comments I changed at https://github.com/JuliaLang/julia/pull/20906/files to reflect this

Thanks for sorting the coincident-merge issue, and shall do! (I should have left a comment in #20886 holding merge till after the indexing changes.) Thanks!

@Sacha0 Sacha0 mentioned this pull request Mar 6, 2017
Merged
@Sacha0
Fixes and stronger tests for SymTridiagonal setindex!.
47bd774 
Makes SymTridiagonal setindex! no longer support off-diagonal assignment of any form.
Strengthens tests for SymTridiagonal setindex!.
Cleans up associated tests for broadcast! with structured-matrix destination.
@Sacha0
Copy link
Member Author

Sacha0 commented Mar 6, 2017

Cleaned up the sparse/higherorderfns tests as suggested above. Thanks!

@andreasnoack andreasnoack merged commit e3bbd26 into JuliaLang:master Mar 8, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Mar 8, 2017

Thanks all!

@Sacha0 Sacha0 deleted the stdiagsetind branch March 8, 2017 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Milestone
0.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Sacha0 @ararslan @tkelman @andreasnoack