fixes and stronger tests for Tridiagonal setindex! #20892
Conversation
Sacha0
added
bugfix
base/linalg/tridiag.jl
Outdated
| @inbounds A.du[i] = x | ||
| elseif !iszero(x) | ||
| throw(ArgumentError(string("cannot set entry ($i, $j) off the ", | ||
| "main, sub, and super diagonals to a nonzero value ($x)"))) |
There was a problem hiding this comment.
"or" was more correct sounds better IMO
There was a problem hiding this comment.
Will change to "or". (For my benefit, could you explain why "or" strikes you as more correct? Present understanding: "or" seems more correct in e.g. "entry not on a, b, or c", but "and" more correct in "entry off a, b, and c", as an "entry off a, b, or c" could be e.g. off a but on b and c (edit: or just off a but on b, in the mutually exclusive case)? Thanks!)
There was a problem hiding this comment.
I'm pretty sure the word you guys are looking for is nor, as in "cannot set the entry off the main, sub, nor super diagonals"
There was a problem hiding this comment.
Lacking an explicit preceding negative, "nor" does not seem correct? ("off" being the relevant preceding word, not "cannot".)
There was a problem hiding this comment.
If it's a scalar entry, then it's only going to be in one of the diagonals, not multiple. There's an argument for multiple ways of saying this, guess it's more what sounds better. The condition for it working is that it has to be in one of the 3, the condition that caused the error was that it wasn't in any of the 3.
There was a problem hiding this comment.
Perhaps sidestepping this wording conundrum altogether is best: "cannot set entry (1, 2) off the tridiagonal band to a nonzero value (3)". Thoughts? Thanks!
Makes Tridiagonal setindex! support assigning zero off the main, sub, and super diagonals. Strengthens tests for Tridiagonal setindex!.
|
Thanks all! |
Ref. discussion in #20886. This pull request makes
Tridiagonalsetindex!support zero-assignment off the main, sub, and super diagonals, and expands and strengthens tests forTridiagonalsetindex!. Best!