Fix #17680 (sparse general concatenation) and #17686 (concatenation of heterogeneous Matrix-Vector combinations) #17690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request's first commit makes general concatenations (
cat
) of combinations of sparse matrices with sparse matrices or dense matrices/vectors yield sparse arrays, addressing #17680.The second commit makes
hvcat
s of heterogeneous combinations of dense matrices and vectors yield dense arrays, addressing #17686. The third commit removes seemingly redundant dense array concatenation methods and cleans up the corresponding code.Given the performance sensitivity of these concatenation methods, would one of the powers that be ask Nanosoldier to perf test this? Thanks and best!