Skip to content

Fix #17680 (sparse general concatenation) and #17686 (concatenation of heterogeneous Matrix-Vector combinations) #17690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2016

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jul 28, 2016

This pull request's first commit makes general concatenations (cat) of combinations of sparse matrices with sparse matrices or dense matrices/vectors yield sparse arrays, addressing #17680.

The second commit makes hvcats of heterogeneous combinations of dense matrices and vectors yield dense arrays, addressing #17686. The third commit removes seemingly redundant dense array concatenation methods and cleans up the corresponding code.

Given the performance sensitivity of these concatenation methods, would one of the powers that be ask Nanosoldier to perf test this? Thanks and best!

@JeffBezanson
Copy link
Member

Would be good to also reference the numbers of the fixed issues in the commit messages.

…s with sparse matrices or dense matrices/vectors yield sparse arrays (fixes JuliaLang#17680).
@Sacha0
Copy link
Member Author

Sacha0 commented Jul 29, 2016

Would be good to also reference the numbers of the fixed issues in the commit messages.

Added. Thanks!

@kshyatt kshyatt added linear algebra Linear algebra sparse Sparse arrays types and dispatch Types, subtyping and method dispatch labels Jul 29, 2016
@JeffBezanson JeffBezanson removed the types and dispatch Types, subtyping and method dispatch label Jul 29, 2016
@tkelman
Copy link
Contributor

tkelman commented Jul 29, 2016

any difference between this and jeff's version at 28ec527?

(whoops, missed #17689)

@tkelman
Copy link
Contributor

tkelman commented Jul 29, 2016

it's running the nightly build right now, but hopefully only that @nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@martinholters
Copy link
Member

Performance delta looks like measurement noise.

@JeffBezanson JeffBezanson merged commit ba46baf into JuliaLang:master Jul 29, 2016
@Sacha0
Copy link
Member Author

Sacha0 commented Jul 29, 2016

Thanks for the reviews and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants