Inferrable ntuple without generated functions #15578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| # inferrable ntuple | ||
| function ntuple{F,N}(f::F, ::Type{Val{N}}) | ||
| check_parameter_type(Int, N, :ntuple) |
There was a problem hiding this comment.
This can be done with Core.typeassert(N, Int).
|
👍 |
|
I just realized how much similarity this has with your #15516, though AFAICT there isn't actual overlap. |
timholy
force-pushed
the
teh/lispy_ntuple
branch
from
14476d6 to
7f62112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trick seems to be adding the
::Ftype parameter, see #15456. Third time's the charm 😄.