Fix type stability of ReadEachIterator

Its `eltype` method had an incorrect type declaration.
JuliaLang · Nov 24, 2024 · 98ad324 · 98ad324
1 parent 0bedaae
commit 98ad324
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/base/io.jl b/base/io.jl
@@ -1382,7 +1382,7 @@ readeach(stream::IOT, T::Type) where IOT<:IO = ReadEachIterator{T,IOT}(stream)
 iterate(itr::ReadEachIterator{T}, state=nothing) where T =
     eof(itr.stream) ? nothing : (read(itr.stream, T), nothing)
 
-eltype(::Type{ReadEachIterator{T}}) where T = T
+eltype(::Type{<:ReadEachIterator{T}}) where T = T
 
 IteratorSize(::Type{<:ReadEachIterator}) = SizeUnknown()
 

diff --git a/test/read.jl b/test/read.jl
@@ -378,6 +378,8 @@ for (name, f) in l
         verbose && println("$name readeach...")
         @test collect(readeach(io(), Char)) == Vector{Char}(text)
         @test collect(readeach(io(), UInt8)) == Vector{UInt8}(text)
+        @test eltype(readeach(io(), Char)) <: Char
+        @test eltype(readeach(io(), UInt8)) <: UInt8
 
         cleanup()