Skip to content

Commit

Permalink
Remove overwritten method of OffsetArray (#56414)
Browse files Browse the repository at this point in the history
This is overwritten three definitions later in
`Base.reshape(A::OffsetArray, inds::Colon)`.

Should remove warnings I saw when testing a package that uses it.
  • Loading branch information
JamesWrigley authored Nov 1, 2024
1 parent 4393f8c commit 770b144
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/testhelpers/OffsetArrays.jl
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,6 @@ Base.reshape(A::OffsetArray, inds::Tuple{Union{Integer,Base.OneTo},Vararg{Union{
Base.reshape(A::OffsetArray, inds::Dims) = _reshape_nov(A, inds)
Base.reshape(A::OffsetVector, ::Colon) = A
Base.reshape(A::OffsetVector, ::Tuple{Colon}) = A
Base.reshape(A::OffsetArray, ::Colon) = reshape(A, (Colon(),))
Base.reshape(A::OffsetArray, inds::Union{Int,Colon}...) = reshape(A, inds)
Base.reshape(A::OffsetArray, inds::Tuple{Vararg{Union{Int,Colon}}}) = _reshape_nov(A, inds)
# The following two additional methods for Colon are added to resolve method ambiguities to
Expand Down

0 comments on commit 770b144

Please sign in to comment.