-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: highlight when deps have different loaded versions #4109
Merged
IanButterworth
merged 10 commits into
JuliaLang:master
from
IanButterworth:ib/status_different_loaded_versions
Dec 9, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
81df5e6
status: highlight when deps have different loaded versions
IanButterworth 31655d2
use src path to determine difference
IanButterworth d61fabb
debug
IanButterworth 854575f
fixup
IanButterworth fbfd7d5
shorten and expand
IanButterworth 0ba6a75
add test
IanButterworth 30d9f4f
add news
IanButterworth 82afbea
Merge branch 'master' into ib/status_different_loaded_versions
IanButterworth a75a0bd
Update new.jl
IanButterworth 1057169
Merge branch 'ib/status_different_loaded_versions' of github.com:IanB…
IanButterworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are so many ways to get the path to a package, could also for example use
pkgorigins
but this should be fine as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgorigins
only works for loaded packages? This line's the src as found based on the env, i.e. what loading would find. I thoughtlocate_package
would be the closest to the actual loading mechanics? If there's a more proper way then let's use itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead, the docs seem to support this being the correct API https://github.com/JuliaLang/julia/blob/e0656ac017a427f739f985809017a33c269b3af1/base/loading.jl#L496-L512