Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport artifact rename to 1.11 #4099

Merged

Conversation

visr
Copy link
Contributor

@visr visr commented Nov 28, 2024

#4001 was marked with a backport-1.11 label but wasn't part of #4037. It did get in 1.10 with #4036.

This also includes #3827 since it is a related improvement and by adding both it avoids merge conflicts.

As suggested by @IanButterworth in https://discourse.julialang.org/t/error-ioerror-rm-c-users-35879-julia-artifacts-jl-wek1vy-bin-directory-not-empty-enotempty/123142/6?u=visr.

nhz2 added 2 commits November 28, 2024 16:29
* try rm to get better error messages

* simplify changes

* fix comment typo

* rethrow InterruptException

* Update error message

* remove redundant error logging

(cherry picked from commit 8b2c0f3)
(cherry picked from commit bc51db7)
@IanButterworth
Copy link
Member

Thanks. Not sure what happened with my backports PR. Thanks for catching and fixing.

@IanButterworth IanButterworth merged commit d314327 into JuliaLang:release-1.11 Nov 28, 2024
7 checks passed
@visr visr deleted the backport-artifact-rename-1.11 branch November 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants