Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the NetworkOptions.__diagnostics__() function #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 16, 2022

See JuliaLang/julia#43834 (comment) for context.


Example output if no relevant environment variables are set:

julia> NetworkOptions.__diagnostics__(stdout)
Relevant environment variables: [none]

Example output if one or more relevant environment variables are set:

julia> NetworkOptions.__diagnostics__(stdout)
Relevant environment variables:
  SSH_KEY_PASS:  ***
  SSL_CERT_DIR:  ***
  SSL_CERT_FILE: ***

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #21 (23c86a3) into master (4d3df64) will decrease coverage by 9.32%.
The diff coverage is 44.44%.

❗ Current head 23c86a3 differs from pull request most recent head 44259fd. Consider uploading reports for the commit 44259fd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   97.63%   88.31%   -9.33%     
==========================================
  Files           4        5       +1     
  Lines         127      154      +27     
==========================================
+ Hits          124      136      +12     
- Misses          3       18      +15     
Impacted Files Coverage Δ
src/NetworkOptions.jl 100.00% <ø> (ø)
src/diagnostics.jl 44.44% <44.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3df64...44259fd. Read the comment docs.

@DilumAluthge DilumAluthge force-pushed the dpa/networkoptions-diagnostics branch 3 times, most recently from 699a697 to fcfbbcc Compare February 16, 2022 03:01
@KristofferC
Copy link
Member

crossposting JuliaLang/Pkg.jl#2992 (comment) here.

@StefanKarpinski
Copy link
Member

I'd rather make this an official API and not hide it with underscores. It also seems like it might be better to return a data structure, perhaps one that looks sane when printed as a TOML data structure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants