allow passing ipiv to lu! factorizations #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Nov 29, 2024
stevengj
added
enhancement
|
Should this go in the new LinearAlgeba.jl repo instead? |
Co-authored-by: Steven G. Johnson <[email protected]>
|
Isn't this the new LinearAlgebra Repo? |
|
Whoops, right. Sorry, I thought was looking at |
|
An alternative API would be: lu!(F::LU, A::StridedMatrix, ...)that lets you overwrite an existing Indeed, it looks like we already have such a method for LU factorization of |
|
closing in favor of #1131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when performing LU factorizations, a
Vector{BlasInt}is allocated each time. in conjuction with a matrixA.lu!allows reusing a matrix, but it still allocates the vector. This PR allows passingipivas an input tolu!, so no allocations are performed, if required.