Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get types of memory{T} #32

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Get types of memory{T} #32

merged 2 commits into from
Nov 14, 2023

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Nov 8, 2023

No description provided.

@topolarity topolarity self-requested a review November 8, 2023 19:38
@topolarity topolarity linked an issue Nov 12, 2023 that may be closed by this pull request
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test coverage?

Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally convinced about the new alloc_type export, but we can bikeshed that tomorrow.

Otherwise, nice work!

@topolarity topolarity merged commit 7f7d9a3 into main Nov 14, 2023
3 of 4 checks passed
topolarity added a commit that referenced this pull request Nov 23, 2023
topolarity added a commit that referenced this pull request Nov 23, 2023
topolarity added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust to Memory{T} changes
2 participants