Use rem2pi and rem with BigFloats in _quadrant #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use
rem2pi
andrem
withBigFloat
s, instead of the same methods for the specificAbsrtracFloat
s. The reason is that, in order to guarantee the precision one needs more "guard digits" than the actual precision; see J-M Muller, "Elementary Functions: Algorithms and implementations", Birkhäuser, 3rd ed (2005), chap. 11. While the solution to useBigFloat
s should have a performance impact, it seems to be at least safe, without implementing more elaborate range reduction methods.The following illustrates such a case:
As far as I have checked, or the tests show, there haven't been any issues with this change.
This approach could be adapted for the
mod
(or should it berem
?) function; cf #129, #145 and #178).