-
Notifications
You must be signed in to change notification settings - Fork 60
Implement of the RClass idea #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great, I have a brutalist version of my code (EcoJulia/Phylo.jl#3) that uses this and it seems to work using |
|
Would it be crazy to create a submodule like |
There are too many functions falling into this category. I am not sure if it becomes necessary if most of the internal functions are put in say, |
Yes, I assumed there would be lots of them tbh, which was why I thought something like |
So, I'm completely happy with this, and I don't want to open a can of worms, but when multiple people start providing converters for the same R type, is there going to be a way forward? As things stand (if I understand Julia multiple dispatch correctly, which I probably don't!) are they going to overwrite one another, with the last man standing? That may be fine of course, but I thought I ought to raise it... |
I believe only the last overload counts (untested). I guess there is no easy fix for this. Since there should be one and only one output, it should not be very bad to use the last known type. |
Yes, that's what I thought. I guess it's okay - it would be a strange situation using two different Julia types in a single piece of code that match the same R type (and wanting to do conversions!). |
close #138
An example of usage can be found in datatime.jl.
@richardreeve, I guess you may be interested in it.