Skip to content

Fix0.7 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix0.7 #64

wants to merge 2 commits into from

Conversation

daschw
Copy link
Contributor

@daschw daschw commented Jul 5, 2018

The tests still fail:

(v0.7) pkg> test ImageFiltering
  Updating registry at `~/.julia/registries/Uncurated`
  Updating git-repo `https://github.com/JuliaRegistries/Uncurated.git`
   Testing ImageFiltering
 Resolving package versions...
Skipping Base.active_repl
Skipping Base.active_repl_backend
Skipping Base.active_repl
Skipping Base.active_repl_backend
padarray: Test Failed at /home/dani/.julia/dev/ImageFiltering/test/border.jl:134
  Expression: occursin("element type ColorTypes.RGB", (ret.value).msg)
Stacktrace:
 [1] macro expansion at /home/dani/.julia/dev/ImageFiltering/test/border.jl:142 [inlined]
 [2] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v0.7/Test/src/Test.jl:1080 [inlined]
 [3] macro expansion at /home/dani/.julia/dev/ImageFiltering/test/border.jl:6 [inlined]
 [4] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v0.7/Test/src/Test.jl:1080 [inlined]
 [5] top-level scope at /home/dani/.julia/dev/ImageFiltering/test/border.jl:5 [inlined]
 [6] top-level scope at ./<missing>:0
Test Summary: | Pass  Fail  Total
Border        |   78     1     79
  padarray    |   51     1     52
  Pad         |    9            9
  Inner       |    7            7
  Fill        |    9            9
  misc        |    2            2
ERROR: LoadError: LoadError: Some tests did not pass: 78 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /home/dani/.julia/dev/ImageFiltering/test/border.jl:4
in expression starting at /home/dani/.julia/dev/ImageFiltering/test/runtests.jl:10
ERROR: Package ImageFiltering errored during testing

@timholy
Copy link
Member

timholy commented Jul 9, 2018

Thanks so much! Just FYI I'm working my way up towards this, starting with getting all dependencies passing.

@timholy
Copy link
Member

timholy commented Aug 17, 2018

Incorporated into #65

@timholy timholy closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants