Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Slicing #589

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Draft: Slicing #589

merged 4 commits into from
Sep 1, 2024

Conversation

JonasIsensee
Copy link
Collaborator

Implements a dataset wrapper ArrayDataset that allows typestable slicing and update of array datasets using the getindex and setindex! API.

@JonasIsensee JonasIsensee changed the base branch from master to dev August 31, 2024 14:23
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (8b6dbbc) to head (5d592ea).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
src/data/reconstructing_datatypes.jl 92.30% 1 Missing ⚠️
src/datasets.jl 85.71% 1 Missing ⚠️
src/explicit_datasets.jl 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #589      +/-   ##
==========================================
+ Coverage   85.04%   85.26%   +0.21%     
==========================================
  Files          36       36              
  Lines        4434     4438       +4     
==========================================
+ Hits         3771     3784      +13     
+ Misses        663      654       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasIsensee JonasIsensee merged commit f7bd29b into dev Sep 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant