CompatHelper: bump compat for TranscodingStreams to 0.10, (keep existing compat) #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JonasIsensee
force-pushed
the
compathelper/new_version/2023-10-15-01-12-07-989-03826727764
branch
from
909ce91
to
6cf1fd8
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
==========================================
- Coverage 85.94% 85.92% -0.03%
==========================================
Files 31 31
Lines 4227 4226 -1
==========================================
- Hits 3633 3631 -2
- Misses 594 595 +1 ☔ View full report in Codecov by Sentry. |
|
Can someone take a look at these tests (they appear to be the same on master??) and merge and release this as a patch (if appropriate). It would alleviate some compat pain in the ecosystem. |
|
thanks @JonasIsensee. The "urgent" label was a bit strong, but I couldn't think of a better name |
|
@IanButterworth You're welcome. |
IanButterworth
deleted the
compathelper/new_version/2023-10-15-01-12-07-989-03826727764
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
TranscodingStreamspackage from0.9to0.9, 0.10.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.