Update to ImageMagick 7 library that almost works. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also Fixes #231 |
|
Does anyone know how #206 was fixed? Just by reverting the library? The issue seems like it's some odd interaction with libtiff. |
|
Here are relevant links: |
|
(Apologies -- not sure how I closed it.) |
|
Yes, I think we reverted it. |
|
@dgleich Gave you commit access here (in case it helps). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
But this still causes the issue with #206. I'm not quite sure how that one got changed, but it seems like it was another issue outside of the core library. So I'm starting this pull request to debug further.
This also bumps the version number to 1.4.0 because there could be other things that change with the version 7 library.
Do we want to add webp support as part of this too?