Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tiffimages version #66

Merged
merged 3 commits into from
May 13, 2024
Merged

bump tiffimages version #66

merged 3 commits into from
May 13, 2024

Conversation

tlnagy
Copy link
Contributor

@tlnagy tlnagy commented Mar 19, 2024

No description provided.

@tlnagy
Copy link
Contributor Author

tlnagy commented Mar 21, 2024

@sjkelly do you mind merging this when you get a chance? The CI failure appears unrelated.

@sjkelly
Copy link
Member

sjkelly commented Mar 22, 2024

Hmm it looks like CI didn't run at all though...

@stemann
Copy link
Contributor

stemann commented Apr 21, 2024

#68 should fix CI (except for Invalidations) fixed CI

@asinghvi17 asinghvi17 closed this May 8, 2024
@asinghvi17 asinghvi17 reopened this May 8, 2024
Project.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (2ea85e8) to head (c2cf896).
Report is 58 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   69.23%   94.93%   +25.70%     
===========================================
  Files           1        1               
  Lines          26       79       +53     
===========================================
+ Hits           18       75       +57     
+ Misses          8        4        -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,7 +1,7 @@
name = "ImageIO"
uuid = "82e4d734-157c-48bb-816b-45c225c6df19"
authors = ["Ian Butterworth"]
version = "0.6.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this PR, but the repo is missing a tag/release for 0.6.7 it seems...

Copy link
Member

@IanButterworth IanButterworth May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, but TagBot isn't happy even though I updated it to latest config and refreshed the DOCUMENTER_KEY etc. so I had to make a manual release after the tag was made

Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going off tests passing, and TiffImages 0.10 being used in tests, this LGTM.

However, we claim to support a lot of older TiffImages versions. Maybe that's true but it highlights the general need to test lower compat bounds too

@IanButterworth IanButterworth merged commit 2a06e0b into JuliaIO:master May 13, 2024
20 checks passed
@tlnagy tlnagy deleted the patch-1 branch May 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants