Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move set_blosc! methods to H5ZBlosc.jl #1167

Merged
merged 9 commits into from
Nov 14, 2024
+21 −19
Merged

Move set_blosc! methods to H5ZBlosc.jl #1167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93e0f6b
Move `set_blosc!` methods to H5ZBlosc.jl
topolarity Oct 9, 2024
d91501e
Bump `docs` Manifest.toml
topolarity Oct 9, 2024
6993573
Fix downstream CI to dev filter packages
topolarity Oct 10, 2024
330ee06
Bump `H5Zblosc` version number and add compat bound
topolarity Oct 10, 2024
59d6e46
Remove H5Zblosc `[compat]` bound
topolarity Oct 28, 2024
502ea93
Merge branch 'master' into ct/mv-blosc
mkitti Nov 14, 2024
cb3c6f4
Move code to BloscExt rather H5Zblosc, reconcile other changes
mkitti Nov 14, 2024
dcab974
Refer to BloscExt.BloscFilter rather than H5Zblosc.BloscFilter
mkitti Nov 14, 2024
92e6844
Remove Julia 1.6 references from CI.yml
mkitti Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,14 @@ jobs:
using Pkg
try
# force it to use this PR's version of the package
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
Pkg.develop(PackageSpec[ # resolver may fail with main deps
PackageSpec(path="."),
PackageSpec(path="./filters/H5Zbitshuffle"),
PackageSpec(path="./filters/H5Zblosc"),
PackageSpec(path="./filters/H5Zbzip2"),
PackageSpec(path="./filters/H5Zlz4"),
PackageSpec(path="./filters/H5Zzstd"),
])
Pkg.update()
Pkg.test() # resolver may fail with test time deps
catch err
Expand Down
1 change: 1 addition & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ MPIExt = "MPI"

[compat]
Compat = "3.1.0, 4"
H5Zblosc = "≥ 0.1.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be covered by the compat in H5Zblosc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - it should be bumped / tightened whenever this falls into a release, but doing the compat on the H5Zblosc side is probably right

HDF5_jll = "~1.10.5, ~1.12.0, ~1.14.0"
MPI = "0.20"
MPIPreferences = "0.1.7"
Expand Down
Loading
Loading